Skip to content

Conversation

@phlax
Copy link
Member

@phlax phlax commented Oct 21, 2025

No description provided.

@phlax phlax marked this pull request as draft October 21, 2025 10:20
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 21, 2025
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #41631 was opened by phlax.

see: more, trace.

@phlax phlax force-pushed the deps-rm-intelittapi branch from 2e90434 to d831289 Compare October 21, 2025 13:59
Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax force-pushed the deps-rm-intelittapi branch from d831289 to b2cb9cb Compare October 21, 2025 14:15
@phlax phlax changed the title [WIP/TESTING] deps: Rm unused intel_ittapi deps: Rm unused intel_ittapi Oct 21, 2025
@phlax phlax marked this pull request as ready for review October 21, 2025 14:29
@phlax
Copy link
Member Author

phlax commented Oct 21, 2025

cc @PiotrSikora not sure if this is safe to remove - we certainly arent building/testing it in any of our builds - the only thing that fails on removal is running bazel query - im not entirely clear why that is

would be great to get confirmation either way

we could probably avoid the patch - its already selected with a default of false - but for some reason i couldnt figure out, it is still included by running query

@PiotrSikora
Copy link
Contributor

This was added recently by @leonm1 as part of V8 update, presumably for a reason, but I don't have any context here.

cc @mpwarres

@phlax
Copy link
Member Author

phlax commented Oct 21, 2025

apologies - for some reason i thought you had the background to it - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies waiting:any

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants