Skip to content

Flake #41606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Flake #41606

wants to merge 2 commits into from
+15 −9

Conversation

@efimki
Copy link
Member

@efimki efimki commented Oct 17, 2025 •
edited
Loading

Commit Message: Fix flaky client_side_weighted_round_robin:integration_test.

  • Increase connection timeout.
  • Add sleeps between requests
  • Add codec_client_->waitForDisconnect() after cleanupUpstreamAndDownstream();
  • Reduce number of requests.

Risk Level: Low
Testing: bazel test //test/extensions/load_balancing_policies/client_side_weighted_round_robin:integration_test --config=compile-time-options --define admin_functionality=disabled --runs_per_test=100 --cache_test_results=no

Fixes #issue

efimki added 2 commits October 17, 2025 13:09
@efimki
Try to fix the flake in CSWRR integration test.
2174822 
Signed-off-by: Misha Efimov <[email protected]>
@efimki
Test succeeds: bazel test //test/extensions/load_balancing_policies/c…
1c75913 
…lient_side_weighted_round_robin:integration_test --config=compile-time-options --define admin_functionality=disabled --runs_per_test=100 --cache_test_results=no

Signed-off-by: Misha Efimov <[email protected]>
@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Oct 17, 2025

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #41606 was opened by efimki.

see: more, trace.

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbpcode wbpcode Awaiting requested review from wbpcode wbpcode will be requested when the pull request is marked ready for review wbpcode is a code owner

@adisuissa adisuissa Awaiting requested review from adisuissa adisuissa will be requested when the pull request is marked ready for review adisuissa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

stale stalebot believes this issue/PR has not been touched recently

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@efimki