deps/protoprocess: Resolve compiler warnings #36568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
changed the title
|
upstream PR is here grpc-ecosystem/proto_processing_lib#5 running this here to ensure it resolves the issue/s and doesnt break anything, but if upstream is not landed before release then i think we should land this |
|
seems to fix the problem and doesnt break anything (related) |
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
deps-patch-proto_processing
branch
from
9c80c94 to
37e9087
Compare
phlax
changed the title
mattklein123
approved these changes
Oct 15, 2024
repokitteh-read-only
bot
removed
the
deps
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Gustavo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.