[WIP] deps: Bump rules_antlr -> 0.5.0, antlr_runtimes -> 4.9.2

[phlax]

Signed-off-by: Ryan Northey [email protected]

Commit Message: deps: Bump rules_antlr -> 0.5.0
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #18342 Fix #18316
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18523 was opened by phlax.

see: more, trace.

[phlax]

fails with

ERROR: error loading package '': in /source/bazel/dependency_imports.bzl: cannot load '@rules_antlr//antlr:deps.bzl': no such file

[moderation]

This is another one that will need to be bumped with the WASM stuff. You may need to bump the Antlr runtime and I know the way to configure that in Bazel changed a lot in 4.8.

[phlax]

currently 4.9.1+ is not supported by rules_antlr - not sure what the hold up is, but the PR to resolve is here https://github.com/marcohu/rules_antlr/pull/14/files

not sure that fixes the problem we are seeing in CI about missing re/moved deps.bzl

[moderation]

This is another one that is WASM related. I have it working in my local branch but without @PiotrSikora and team engaged it is hard to bump these deps in isolation.

diff --git a/bazel/dependency_imports.bzl b/bazel/dependency_imports.bzl
index b382e3fd0..7f217c45b 100644
--- a/bazel/dependency_imports.bzl
+++ b/bazel/dependency_imports.bzl
@@ -6,12 +6,12 @@ load("@build_bazel_rules_apple//apple:repositories.bzl", "apple_rules_dependenci
 load("@rules_fuzzing//fuzzing:repositories.bzl", "rules_fuzzing_dependencies")
 load("@upb//bazel:workspace_deps.bzl", "upb_deps")
 load("@rules_rust//rust:repositories.bzl", "rust_repositories")
-load("@rules_antlr//antlr:deps.bzl", "antlr_dependencies")
+load("@rules_antlr//antlr:repositories.bzl", "rules_antlr_dependencies")
 load("@proxy_wasm_rust_sdk//bazel:dependencies.bzl", "proxy_wasm_rust_sdk_dependencies")
 load("@rules_cc//cc:repositories.bzl", "rules_cc_dependencies", "rules_cc_toolchains")

 # go version for rules_go
-GO_VERSION = "1.15.5"
+GO_VERSION = "1.17.2"

 def envoy_dependency_imports(go_version = GO_VERSION):
     # TODO: allow building of tools for easier onboarding
@@ -22,7 +22,7 @@ def envoy_dependency_imports(go_version = GO_VERSION):
     apple_rules_dependencies()
     rust_repositories()
     upb_deps()
-    antlr_dependencies(472)
+    rules_antlr_dependencies("4.8")
     proxy_wasm_rust_sdk_dependencies()
     rules_fuzzing_dependencies(

[phlax]

ill add ~your patch as i think that will get us past the deps.bzl issue at least

not sure if the go bump is required, but probs best to do that elsewhere (/first if required)

[moderation]

Ignore go version - that is just what I run locally and it should be changed in the multiple rules_go PRs out there

[phlax]

k, so now it fails on the expected rules_antlr compat - i guess this one can wait until that has been updated

[phlax]

i guess this one can wait until that has been updated

checking this further - the repo seems to be unmaintained - i opened a ticket to clarify this here marcohu/rules_antlr#19

I have also created a PR to update with a patch for 4.9.2 runtime here marcohu/rules_antlr#20 and ive set this PR to use the patch

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!