images: Remove centos build image #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
remove-centos-build-image
branch
from
07edb61 to
a93f17c
Compare
|
it seems as tho some users were using this image for building Envoy against lower versions of GLIBC in order to support centos7 (cf envoyproxy/envoy#18365) im not sure if using this (unmaintained) image is the best way to do that, and it seems doing so is now broken anyway |
|
I think it is better if we will try to fix problems of build for centos7. Because envoy is working well on centos7. You honestly write that you do not support it, but anyone can try to build if he wants. Why delete |
|
i agree that it would be good to maintain support for a centos7 build, im just not sure that this build-image is the best way to do that |
|
closing in favour of #356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #149