Skip to content

Commit

Permalink
Added unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
vpaturet committed Jun 11, 2024
1 parent 4f55161 commit 19d727b
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import org.springframework.security.access.AccessDeniedException;

import java.util.Collection;
import java.util.List;
import java.util.Set;

import static org.rutebanken.helper.organisation.AuthorizationConstants.*;
Expand All @@ -24,7 +25,11 @@ public DefaultAuthorizationService(DataScopedAuthorizationService dataScopedAuth

@Override
public void verifyCanEditAllEntities() {
if (roleAssignmentExtractor.getRoleAssignmentsForUser()
verifyCanEditAllEntities(roleAssignmentExtractor.getRoleAssignmentsForUser());
}

void verifyCanEditAllEntities(List<RoleAssignment> roleAssignments) {
if (roleAssignments
.stream()
.noneMatch(roleAssignment -> ROLE_EDIT_STOPS.equals(roleAssignment.getRole())
&& roleAssignment.getEntityClassifications() != null
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package org.rutebanken.tiamat.auth;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.rutebanken.helper.organisation.RoleAssignment;
import org.springframework.security.access.AccessDeniedException;

import java.util.List;

class DefaultAuthorizationServiceTest {

@Test
void verifyCanEditAllEntities() {
List<RoleAssignment> roleAssignments = RoleAssignmentListBuilder.builder().withAccessAllAreas().build();
DefaultAuthorizationService defaultAuthorizationService = new DefaultAuthorizationService(null, null);
Assertions.assertDoesNotThrow(() -> defaultAuthorizationService.verifyCanEditAllEntities(roleAssignments));
}

@Test
void verifyCanEditAllEntitiesMissingRoleAssignment() {
List<RoleAssignment> roleAssignments = RoleAssignmentListBuilder.builder().build();
DefaultAuthorizationService defaultAuthorizationService = new DefaultAuthorizationService(null, null);
Assertions.assertThrows(AccessDeniedException.class, () -> defaultAuthorizationService.verifyCanEditAllEntities(roleAssignments));
}
}

0 comments on commit 19d727b

Please sign in to comment.