Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CodeQL options #76

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: CodeQL options #76

wants to merge 2 commits into from

Conversation

t-bern
Copy link

@t-bern t-bern commented Jan 28, 2025

SIK-1351

@@ -39,6 +49,19 @@ jobs:
exit(1)

os.system('echo Validation passed')"
- name: "Validate input custom runner"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenker python koden her fint kan beveges opp i forrige steg.

run: |
python -c "import os
custom_runner = os.environ['CUSTOM_RUNNER']
supported_runners = ['ubuntu-24.04', 'grp-ubuntu-24.04-2core-x64', 'grp-ubuntu-24.04-8core-x64', 'grp-ubuntu-24.04-16core-x64']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gjerne legg til en kommentar her som linker til doc med liste over grupper.

@@ -349,7 +372,7 @@ jobs:
# See https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#scanning-on-push
# If we found a language, and the event is not a push made by dependabot on a PR
if: ${{ needs.get-repository-languages.outputs.codeql_languages != '[]' && (github.event != 'push' || (github.event == 'push' && github.actor != 'dependabot[bot]')) }}
runs-on: ubuntu-24.04
runs-on: ${{ inputs.custom_runner }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette vil nok ikke fungere, da custom runnerene til Platform må spesifiseres gjennom group. Se https://enturas.atlassian.net/wiki/spaces/ESP/pages/4989059095/GitHub+Actions+Runners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants