Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Language detection & errors on dependabot pushes #54

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

EnturWilhelm
Copy link
Contributor

@EnturWilhelm EnturWilhelm commented Nov 6, 2024

Closes SIK-1176.

Fixes:

  • Language detection
  • Dependabot errors on PR branch pushes (not pull_request open events)
  • Formatting errors

Due to the formatting changes and standardizing the indentation level across both workflows (which was a mix of 4 and 2 spaces before), the PR looks much bigger than it actually is.

The major changes are here:

@EnturWilhelm EnturWilhelm changed the title Fix/bugfixes langdetection fix: Language detection & errors on dependabot pushes Nov 6, 2024
@EnturWilhelm EnturWilhelm marked this pull request as ready for review November 6, 2024 13:00
@EnturWilhelm EnturWilhelm requested a review from a team as a code owner November 6, 2024 13:00
@EnturWilhelm EnturWilhelm requested a review from cvaskinn November 6, 2024 13:00
Copy link
Contributor

@cvaskinn cvaskinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta en gjennomgang av kommentarene

.github/workflows/code-scan.yml Show resolved Hide resolved
.github/workflows/code-scan.yml Show resolved Hide resolved
.github/workflows/code-scan.yml Outdated Show resolved Hide resolved
.github/workflows/code-scan.yml Outdated Show resolved Hide resolved
.github/workflows/code-scan.yml Show resolved Hide resolved
@EnturWilhelm EnturWilhelm merged commit 1302531 into main Nov 7, 2024
2 checks passed
@EnturWilhelm EnturWilhelm deleted the fix/bugfixes-langdetection branch November 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants