Fix ci tests #215
Closed
Fix ci tests #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add isRegistered test
* added pre-registration isRegistered Test, first to expect falsy return and then a toBe equal to 'false'. then a post registration check for isRegistered that expects a truthy return and then a toBe('true')
#213) This commit adds an environment variable, `ENTROPY_BINARY_DIR`, that allows overwriting the location from which the test suite will look for the `entropy` and `server` binaries. I want this so that I can easily test different binary builds. This also makes it easier to use the same tests in CI and other environments, such as for example building locally on a macOS machine locally but with a binary built for GNU/Linux in CI.
frankiebee
force-pushed
the
fix-ci-tests
branch
from
63863cf to
e04755d
Compare
|
closing because we will wait for @vitropy docker containers |
You can track progress for this, by the way, at entropyxyz/entropy-core#446. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub Issue or Linear Task
How Has This Been Tested?