fix: enforce btc network in address validation#319

Open

volcano303 wants to merge 1 commit into

entrius:testfrom

volcano303:fix/btc-network-address-validation

volcano303 commented May 12, 2026

Summary

enforce BTC_NETWORK in BitcoinProvider.is_valid_address
accept only matching bech32 HRP and base58 version bytes for the active network
add regression tests for mainnet/testnet cross-network rejection

Issue

Closes #318

Validation

uv run pytest tests/test_bitcoin_signing.py::TestBitcoinAddressValidationNetwork -q
uv run pytest tests/test_bitcoin_signing.py -q
uv run ruff check allways/ neurons/ tests/test_bitcoin_signing.py
uv run pre-commit run --all-files
uv run pytest tests/


          fix: enforce btc network in address validation

0aa51d6

xiao-xiao-mao Bot added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug