Skip to content

fix(dendrite): skip axon on is_validator RPC failure instead of silently including (#168) #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RUNECTZ33 wants to merge 1 commit into from
+11 −2
Closed

fix(dendrite): skip axon on is_validator RPC failure instead of silently including (#168) #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions allways/cli/dendrite_lite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,17 @@ def discover_validators(
try:
if not contract_client.is_validator(metagraph.hotkeys[uid]):
continue
except Exception:
pass
except Exception as e:
# #168: skip on RPC failure rather than silently including the
# axon. Mirrors the validator-side fix from #73/#92 — falling
# through to axons.append on an unverified hotkey leaks
# non-validators into the broadcast list and produces
# confusing rejections downstream.
bt.logging.debug(
f'Skipping uid={uid} hotkey={metagraph.hotkeys[uid][:12]}...: '
f'is_validator RPC failed: {e}'
)
continue
axons.append(axon)

return axons
Expand Down