Skip to content

fix: reject NaN/inf rates in commitment parser #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dripsmvcp wants to merge 1 commit into
base: test
Choose a base branch
from
Open

fix: reject NaN/inf rates in commitment parser #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions allways/commitments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Shared commitment parsing logic — used by validator, miner, and CLI."""

import math
from typing import List, Optional

import bittensor as bt
Expand Down Expand Up @@ -41,6 +42,11 @@ def parse_commitment_data(raw: str, uid: int = 0, hotkey: str = '') -> Optional[
counter_rate_str = parts[6]
counter_rate = float(counter_rate_str)

if not (math.isfinite(rate) and rate > 0):
return None
if not (math.isfinite(counter_rate) and counter_rate > 0):
return None

if src_chain not in SUPPORTED_CHAINS or dst_chain not in SUPPORTED_CHAINS:
return None

Expand Down