fix: top nav height varying by route (flex shrink lock)#87
Open
jstortoise wants to merge 1 commit into
Open
Conversation
jstortoise
changed the title
jstortoise
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top nav: keep a fixed height across routes
The header sits as the first child in
AppLayout’s column flex stack (height: 100vh,overflow: hidden) above<main>withflexGrow: 1. Flex items default toflex-shrink: 1, so when heavier routes mount, the main area can exert shrink pressure on the header and the bar’s rendered height drifts slightly by route.Change: Treat the header as a fixed-size flex sibling, not a shrinkable one:
flexShrink: 0andflexGrow: 0so<main>cannot compress or stretch the bar.minHeight/maxHeightaligned with the existingheightbreakpoints (xs: 52,md: 56) so the bar stays one locked size.boxSizing: 'border-box'so the bottom border counts inside that height and totals stay consistent.Active vs inactive nav links already both use a 1px bottom border (color only differs), so no link-level style changes were required.