Skip to content

Reservation detail: lift confirming-funds note + drop 'within a block' claims#80

Merged
anderdc merged 1 commit into
testfrom
reservation-detail-copy-cleanup
May 6, 2026
Merged

Reservation detail: lift confirming-funds note + drop 'within a block' claims#80
anderdc merged 1 commit into
testfrom
reservation-detail-copy-cleanup

Conversation

@LandynDev
Copy link
Copy Markdown
Collaborator

Summary

  • Move the "Awaiting source-tx confirmations…" note from a card under the Timeline up to a status-helper line right under the trade summary, mirroring SwapDetailPage's failed-tx layout for cross-page consistency.
  • Drop "— usually within a block" from the Funds-received timeline detail.
  • Replace the Next-step card's "Validators usually pick up the send within a block. The sender address must match — mismatched txs are rejected." with the simpler, accurate "Validators confirm within a few minutes."

Triggered by feedback on https://test.all-ways.io/reservations/0x5ae1c7f7c21d344a17d95abccdfeee0b881503f2b0c1e4a60eeaa00a0afa2fb2.

Test plan

  • Visit an ACTIVE reservation with funds detected — the "Awaiting source-tx confirmations…" note appears just below "Funds detected · confirming", before the Timeline card; the duplicate card under the timeline is gone.
  • Visit an ACTIVE reservation without funds yet — Next-step card reads "Validators confirm within a few minutes." and the timeline's Funds-received row reads "send funds to the miner".
  • EXPIRED / CANCELLED / INITIATED reservations render unchanged.

@anderdc anderdc merged commit 20e6e73 into test May 6, 2026
2 checks passed
@anderdc anderdc deleted the reservation-detail-copy-cleanup branch May 6, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants