chore: remove unused formatTao and formatNumber helpers#47
Open
FairyPigDev wants to merge 1 commit into
Open
Conversation
formatTao and formatNumber are exported from utils/format.ts but never imported anywhere in src/. Amount formatting is handled by formatAmount (which delegates to CHAIN_DECIMALS) and per-callsite toLocaleString, so the helpers are dead code.
FairyPigDev
force-pushed
the
chore/remove-unused-format-helpers
branch
from
d0bdf65 to
be4231b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #46
Summary
formatTaoandformatNumberfromsrc/utils/format.ts— both exports have zero callers acrosssrc/.Why
Amount rendering in the app is handled by
formatAmount(chain-aware viaCHAIN_DECIMALS) or inlinetoLocaleStringat each call site. These two helpers are orphaned dead code.Verified:
```
$ grep -r "formatTao|f" src/
src/utils/format.ts: (only the definitions themselves)
```
Changes
src/utils/format.ts: −11 lines, 0 insertionsTest plan
npm run buildpasses (tsc + vite build)npm run lintpasses (eslint, 0 warnings)