Skip to content

Fix resetting of the error state for FileEditor #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
greschd wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix resetting of the error state for FileEditor #2007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions traitsui/wx/file_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ def update_editor(self):
self._no_update = False
else:
self._file_name.SetValue(self.str_value)
self._reset_error()

def show_file_dialog(self, event=None):
"""Displays the pop-up file dialog."""
Expand All @@ -158,6 +159,13 @@ def get_error_control(self):
"""Returns the editor's control for indicating error status."""
return self._file_name

def _reset_error(self):
"""Resets the error state of the editor."""
if self._error is not None:
self._error = None
self.ui.errors -= 1
self.set_error_state(False)

# -- Traits Event Handlers ------------------------------------------------

@observe("popup:value")
Expand Down Expand Up @@ -228,6 +236,7 @@ def _update(self, file_name):
file_name = splitext(file_name)[0]

self.value = file_name
self._reset_error()
except TraitError as excp:
pass

Expand Down