Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mob] memory widget add title, support clicks and other fixes #5343

Merged
merged 36 commits into from
Mar 19, 2025

Conversation

prateekmedia
Copy link
Member

@prateekmedia prateekmedia commented Mar 17, 2025

Description

Supercharged memory widget with title, sub title and on tap behavior.

Tests

@prateekmedia prateekmedia changed the title [mob] pinch issues of memories widget [mob] memory widget title, clickability and other fixes Mar 17, 2025
@prateekmedia prateekmedia changed the title [mob] memory widget title, clickability and other fixes [mob] memory widget add title, support clicks and other fixes Mar 17, 2025
@prateekmedia prateekmedia marked this pull request as ready for review March 18, 2025 14:21
@prateekmedia prateekmedia requested a review from ua741 March 19, 2025 09:51
android:id="@+id/widget_title"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="Where is the title?"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep default text as empty here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that will be better. These were just test placeholders afterall.

@prateekmedia prateekmedia merged commit a5ef346 into main Mar 19, 2025
2 checks passed
@prateekmedia prateekmedia deleted the migrate-things branch March 19, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants