Support for Chinese Characters by AdRiley · Pull Request #14934 · enso-org/enso

AdRiley · 2026-04-02T08:22:36Z

Pull Request Description

Fixes an issue that if the project is in a folder path in Windows with a UTF-16 character, it fails to launch.

Uses PowerShell to get the folder path (rather than the registry).
Use W version of the Win32 API for controlling the working folder.
Use Win32 API for reading the command line arguments.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

The documentation has been updated, if necessary.
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.
If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.
- If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

JaroslavTulach · 2026-04-08T04:32:56Z

   */
  @CFunction
-  static native int PathFileExistsA(CCharPointer pszPath);
+  static native int PathFileExistsW(CShortPointer pszPath);


replacing the API with PathFileExistsW might be the right direction

the fastest way to test these changes is sbt os-environment/test

builds small native image

runs tests in native image mode

way faster than building enso executable

there is a dedicated test

can it be enhanced with a sample demonstrating paths with non-ASCII characters?

JaroslavTulach

We should be using CTypeConversions, probably.
Great to have a test!

JaroslavTulach · 2026-04-08T15:51:27Z

+  @Test
+  public void changeDirUnicode() throws IOException {
+    var tmpDir = TMP_DIR.newFolder().toPath();
+    var subDir = tmpDir.resolve("使用者");


JaroslavTulach · 2026-04-08T15:59:34Z

+      return null;
    }
-    return path.trim();
+    return asCharBuffer(buffer, length).toString();


I believe we should be using CTypeConversion, if possible:

Suggested change

return asCharBuffer(buffer, length).toString();

return CTypeConversion.toJavaString(buffer, length, StandardCharsets.UTF16_LE);

if that works and the test passes.

JaroslavTulach

please refactor WindowsArguments to the sealed API pattern
consider malloc, but it is OK to keep the MAX_LENGTH if you want
otherwise I am glad we can handle Chines Characters now!

JaroslavTulach · 2026-04-15T16:02:52Z

+function getWindowsDocumentsPath() {
  const out = childProcess.spawnSync(
-    'reg',
+    'powershell',


What if we run on Windows that don't have powershell?

It's been built into Windows since Windows 7 I think - so think ok to assume its there.

JaroslavTulach · 2026-04-15T16:20:08Z

-      var res = PathFileExistsA(cPath.get());
+    try {
+      var buffer = stringAsWCharPtr(full);
+      var res = PathFileExistsW(buffer);


Yes, let's use W version of the API methods.

JaroslavTulach · 2026-04-15T16:22:18Z

Also please provide some description for this PR.

This reverts commit af56ea1.

Custom function to split the arguments (to be replaced with Win32 call).

Java format.

JaroslavTulach · 2026-04-18T06:33:35Z

I've just created Chinese arguments are corrupted by native image on Windows oracle/graal#13359 for GraalVM guys

AdRiley added CI: No changelog needed Do not require a changelog entry for this PR. CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Apr 2, 2026

AdRiley force-pushed the wip/adr/utf8-friendly-getwindowsdocumentspath branch from 2afc141 to b4efa72 Compare April 3, 2026 09:54

JaroslavTulach reviewed Apr 4, 2026

View reviewed changes

Comment thread engine/runner/src/main/java/org/enso/runner/Main.java Outdated

JaroslavTulach reviewed Apr 8, 2026

View reviewed changes

JaroslavTulach approved these changes Apr 8, 2026

View reviewed changes

JaroslavTulach reviewed Apr 10, 2026

View reviewed changes

Comment thread engine/runner/src/main/java/org/enso/runner/Main.java Outdated

JaroslavTulach reviewed Apr 14, 2026

View reviewed changes

Comment thread engine/runner/src/main/java/org/enso/runner/Utils.java Outdated

jdunkerley changed the title ~~powershell version~~ Support for Chinese Characters Apr 15, 2026

jdunkerley marked this pull request as ready for review April 15, 2026 13:22

jdunkerley requested review from 4e6, PabloBuchu, farmaazon, kazcw and vitvakatu as code owners April 15, 2026 13:22

4e6 reviewed Apr 15, 2026

View reviewed changes

Comment thread lib/java/os-environment/src/main/java/org/enso/os/environment/WindowsArguments.java Outdated

Comment thread app/project-manager-shim/src/projectService/ensoRunner.ts Outdated

Comment thread app/project-manager-shim/src/projectService/ensoRunner.ts Outdated

jdunkerley approved these changes Apr 15, 2026

View reviewed changes

jdunkerley force-pushed the wip/adr/utf8-friendly-getwindowsdocumentspath branch from ed1c920 to d089b47 Compare April 15, 2026 14:13

vitvakatu approved these changes Apr 15, 2026

View reviewed changes

Comment thread app/project-manager-shim/src/desktopEnvironment.ts Outdated

JaroslavTulach requested changes Apr 15, 2026

View reviewed changes

AdRiley added 9 commits April 16, 2026 08:53

powershell version

b7fbc1e

logging

485f14b

fix

cd9dd23

fix

0d99e30

pretty

3e44d2b

more logs

b485036

jvm

df07290

Switch to wide versions of windows APIs

1923370

Revert "Switch to wide versions of windows APIs"

5fee9d3

This reverts commit af56ea1.

jdunkerley added 19 commits April 16, 2026 08:53

Possibly working with W version...

b34ac96

Add unicode tests.

4146ba9

Use Unicode function to get command line arguments.

b4d2584

Custom function to split the arguments (to be replaced with Win32 call).

WIP

b3fdb6d

First fully working version!

387d0c3

Remove some of the diagnostics.

a5d617e

Java format.

Move diagnostics in Java to Logger.

6593697

Use Windows API for parsing out command line args.

848727f

Last bits of Java tidy up.

be2429b

Remove unused.

ee7f518

More logging tidy up.

2009d89

More logging tidy up.

e9a95fb

Java format.

25895bd

Java format.

13df435

Reset last bits.

6ea59ce

Prettier.

3c9ace9

Remove console.debug statements.

1f8dab8

PR comments (Part 1).

8929e6d

Use unmanaged.

5752cab

jdunkerley force-pushed the wip/adr/utf8-friendly-getwindowsdocumentspath branch from 9220718 to 5752cab Compare April 16, 2026 09:15

jdunkerley requested a review from JaroslavTulach April 16, 2026 09:28

Drop arg[0] as don't want that in args array.

d435d83

JaroslavTulach approved these changes Apr 16, 2026

View reviewed changes

Arguments at trace.

382cceb

jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Apr 16, 2026

mergify Bot merged commit 69056d0 into develop Apr 16, 2026
81 checks passed

mergify Bot deleted the wip/adr/utf8-friendly-getwindowsdocumentspath branch April 16, 2026 18:53

JaroslavTulach mentioned this pull request Apr 18, 2026

Chinese arguments are corrupted by native image on Windows oracle/graal#13359

Open

4 tasks

JaroslavTulach mentioned this pull request Apr 30, 2026

Resolve Issue with Chinese characters in Path on Windows #14965

Closed

	return asCharBuffer(buffer, length).toString();
	return CTypeConversion.toJavaString(buffer, length, StandardCharsets.UTF16_LE);

Conversation

AdRiley commented Apr 2, 2026 • edited by jdunkerley Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Description

Checklist

Uh oh!

Uh oh!

JaroslavTulach Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach left a comment

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach left a comment

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

jdunkerley Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JaroslavTulach Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

JaroslavTulach commented Apr 15, 2026

Uh oh!

Uh oh!

JaroslavTulach commented Apr 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AdRiley commented Apr 2, 2026 •

edited by jdunkerley

Loading

JaroslavTulach Apr 8, 2026 •

edited

Loading