Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: registry metadata interface #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: registry metadata interface #16

wants to merge 3 commits into from

Conversation

hiddentao
Copy link
Contributor

No description provided.

@hiddentao hiddentao requested a review from Arachnid February 16, 2025 08:07
hiddentao
hiddentao commented Feb 16, 2025
View reviewed changes
Copy link
Contributor Author

@hiddentao hiddentao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure whether metadata generator needed to be replaceable or not, so have gone for it not being so. Also, for the RootRegistry I just override the uri() method as before for efficiency sake. Thus, metadata interfaces only really apply for UserRegistry.

@coveralls
Copy link

coveralls commented Feb 16, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13364088946

Details

  • 16 of 17 (94.12%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.8%) to 61.765%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/src/registry/BaseRegistry.sol 5 6 83.33%
Totals Coverage Status
Change from base Build 13351832110: 3.8%
Covered Lines: 213
Relevant Lines: 333
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arachnid Arachnid Awaiting requested review from Arachnid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiddentao @coveralls