-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Owned resolver #11
Owned resolver #11
Conversation
deploy-proxy-data-param
deploy-proxy-data-param
deploy-proxy-data-param
Pull Request Test Coverage Report for Build 13525074767Details
💛 - Coveralls |
refactor-transparent-to-uups
} | ||
|
||
function isAuthorised(bytes32) internal view override returns (bool) { | ||
return msg.sender == owner(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this use onlyOwner
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean like this ?
function isAuthorised(bytes32) internal view override onlyOwner returns (bool){
return true;
}
We can do that as long as it doesn't have to be feature compatible as the original implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert - I forgot that this was used by an interface we implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted
This reverts commit e14722e.
This is a port of https://github.com/ensdomains/ens-contracts/blob/staging/contracts/resolvers/OwnedResolver.sol but using https://github.com/ensdomains/verifiable-factory to make the resolver verifiable.
It also uses OZ's OwnableUpgradeable instead of Ownable