Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owned resolver #11

Merged
merged 29 commits into from
Feb 26, 2025
Merged

Owned resolver #11

merged 29 commits into from
Feb 26, 2025

Conversation

makoto
Copy link
Member

@makoto makoto commented Feb 5, 2025

This is a port of https://github.com/ensdomains/ens-contracts/blob/staging/contracts/resolvers/OwnedResolver.sol but using https://github.com/ensdomains/verifiable-factory to make the resolver verifiable.
It also uses OZ's OwnableUpgradeable instead of Ownable

@coveralls
Copy link

coveralls commented Feb 5, 2025

Pull Request Test Coverage Report for Build 13525074767

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 58.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/src/resolver/OwnedResolver.sol 7 8 87.5%
Totals Coverage Status
Change from base Build 13351832110: 0.6%
Covered Lines: 200
Relevant Lines: 332

💛 - Coveralls

@makoto makoto marked this pull request as ready for review February 12, 2025 13:56
}

function isAuthorised(bytes32) internal view override returns (bool) {
return msg.sender == owner();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use onlyOwner?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean like this ?

    function isAuthorised(bytes32) internal view override onlyOwner returns (bool){
        return true;
    }

We can do that as long as it doesn't have to be feature compatible as the original implementation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert - I forgot that this was used by an interface we implement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

@makoto makoto merged commit 8d7a975 into main Feb 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants