remove the last of the istanbul ignores (#20)

* remove the last of the istanbul ignores

* remove comments from final bundle

.github/workflows/CI.yml

@@ -1,6 +1,6 @@
 name: CI
 
-on: [push]
+on: [push, pull_request]
 
 jobs:
   build:

src/getContextInfo.ts

@@ -62,7 +62,6 @@ export default function getContextInfo(ssf: Function): ContextInfo {
   let rawStack: string;
   try {
     const err = new Error();
-    /* istanbul ignore else */
     if ((Error as any).captureStackTrace) {
       (Error as any).captureStackTrace(err, ssf);
     }

src/givenError.ts

@@ -16,7 +16,6 @@ export default class GivenError extends Error {
 
     // If a start stack function (ssf) was provided we capture the current stack trace and pass
     // it to the `captureStackTrace` function so we can remove frames that come after it
-    /* istanbul ignore else */
     if ((Error as any).captureStackTrace) {
       (Error as any).captureStackTrace(this, ssf);
     }

src/isValid.ts

@@ -12,11 +12,7 @@ const disallowedProps = [
   '__cache__',
   '__trace__',
   // prototype props
-  ...allProps(
-    // this is a noop function so the contents do not need to be covered
-    /* istanbul ignore next */
-    () => undefined,
-  ),
+  ...allProps(Function.prototype),
 ];
 
 const isValid = (key: string): boolean => !disallowedProps.includes(key);

test/manual-tests/test/getContextInfo.test.js

@@ -5,5 +5,10 @@ function exampleFn() {
   return getContextInfo(exampleFn);
 }
 
-console.log('getContextInfo with no matching test framework');
+console.log('getContextInfo works with no matching test framework');
 assert.deepStrictEqual(exampleFn(), { allowed: true });
+
+delete Error.captureStackTrace
+
+console.log('getContextInfo works with missing captureStackTrace function');
+assert.deepStrictEqual(exampleFn(), { allowed: true });

test/manual-tests/test/givenError.test.js

@@ -0,0 +1,7 @@
+const givenError = require('givens/dist/givenError.js').default
+const assert = require('assert');
+
+delete Error.captureStackTrace
+
+console.log('givenError works when captureStackTrace is missing')
+assert.equal(new givenError('error').message, 'givens: error');

tsconfig.json

@@ -5,6 +5,7 @@
     "module": "commonjs",
     "declaration": false,
     "sourceMap": true,
+    "removeComments": true,
     "outDir": "./build/tsc",
     "strict": true
   },