Skip to content

Conversation

@rymsha
Copy link
Contributor

@rymsha rymsha commented Oct 13, 2025

No description provided.

@rymsha rymsha linked an issue Oct 13, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 86.23519% with 151 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.55%. Comparing base (ba24979) to head (6c76429).

Files with missing lines Patch % Lines
...src/main/java/com/enonic/xp/util/GenericValue.java 33.33% 62 Missing and 4 partials ⚠️
...xp/repo/impl/version/GenericValueDeserializer.java 68.96% 7 Missing and 2 partials ⚠️
.../java/com/enonic/xp/repo/impl/dump/RepoDumper.java 89.23% 7 Missing ⚠️
...n/java/com/enonic/xp/node/NodeVersionMetadata.java 50.00% 1 Missing and 4 partials ⚠️
...ic/xp/core/impl/content/PublishContentCommand.java 92.64% 3 Missing and 2 partials ⚠️
...nonic/xp/core/impl/content/SortContentCommand.java 88.88% 3 Missing and 1 partial ⚠️
.../xp/core/impl/content/UnpublishContentCommand.java 86.66% 2 Missing and 2 partials ⚠️
.../com/enonic/xp/repo/impl/node/NodeServiceImpl.java 87.87% 4 Missing ⚠️
...onic/xp/repo/impl/node/ResolveSyncWorkCommand.java 93.65% 0 Missing and 4 partials ⚠️
...i/src/main/java/com/enonic/xp/node/Attributes.java 89.65% 3 Missing ⚠️
... and 28 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11477      +/-   ##
============================================
- Coverage     86.60%   86.55%   -0.06%     
+ Complexity    19607    19547      -60     
============================================
  Files          2528     2528              
  Lines         66628    66447     -181     
  Branches       5367     5312      -55     
============================================
- Hits          57702    57511     -191     
- Misses         6313     6348      +35     
+ Partials       2613     2588      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rymsha rymsha force-pushed the issue-11273 branch 2 times, most recently from 477efad to c5736e1 Compare October 20, 2025 14:43
@enonic enonic deleted a comment from codacy-production bot Oct 22, 2025
@rymsha rymsha force-pushed the issue-11273 branch 3 times, most recently from ba6d5fb to fb8a997 Compare October 28, 2025 08:51
version( Objects.toString( meta.version(), null ) ).
nodeBlobKey( meta.nodeVersionKey().getNodeBlobKey().toString() ).
indexConfigBlobKey( meta.nodeVersionKey().getIndexConfigBlobKey().toString() ).
accessControlBlobKey( meta.nodeVersionKey().getAccessControlBlobKey().toString() ).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Codacy found a minor Performance issue: Avoid calling toString() on String objects; this is unnecessary.

The issue identified by the PMD linter is that the toString() method is being called on a String object, which is unnecessary because a String is already in its string representation. This can lead to a slight performance overhead, especially if this pattern occurs frequently in the codebase.

To fix the issue, we can simply remove the unnecessary toString() call for the accessControlBlobKey. The code suggestion would be:

Suggested change
accessControlBlobKey( meta.nodeVersionKey().getAccessControlBlobKey().toString() ).
accessControlBlobKey( meta.nodeVersionKey().getAccessControlBlobKey() ).

This comment was generated by an experimental AI tool.

final RepositoryService repositoryService;
final IndexServiceInternal indexServiceInternal;

public Xp8IndexMigrator( final RepositoryService repositoryService, final IndexServiceInternal indexServiceInternal )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ Codacy found a minor CodeStyle issue: Redundant 'public' modifier.

The issue reported by the Checkstyle linter indicates that the public modifier is considered redundant in this context. This usually occurs when the class is defined in a package-private context, meaning it doesn't need an explicit access modifier for its constructor.

To resolve this issue, you can simply remove the public modifier from the constructor. Here’s the suggested change:

Suggested change
public Xp8IndexMigrator( final RepositoryService repositoryService, final IndexServiceInternal indexServiceInternal )
Xp8IndexMigrator( final RepositoryService repositoryService, final IndexServiceInternal indexServiceInternal )

This comment was generated by an experimental AI tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POC: Version Attributes

2 participants