-
Notifications
You must be signed in to change notification settings - Fork 34
POC: Version Attributes #11273 #11477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11477 +/- ##
============================================
- Coverage 86.60% 86.55% -0.06%
+ Complexity 19607 19547 -60
============================================
Files 2528 2528
Lines 66628 66447 -181
Branches 5367 5312 -55
============================================
- Hits 57702 57511 -191
- Misses 6313 6348 +35
+ Partials 2613 2588 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
477efad to
c5736e1
Compare
...re-repo/src/main/java/com/enonic/xp/repo/impl/dump/serializer/json/VersionDumpEntryJson.java
Show resolved
Hide resolved
.../itest/itest-core/src/test/java/com/enonic/xp/core/node/PushNodesCommandPerformanceTest.java
Outdated
Show resolved
Hide resolved
ba6d5fb to
fb8a997
Compare
| version( Objects.toString( meta.version(), null ) ). | ||
| nodeBlobKey( meta.nodeVersionKey().getNodeBlobKey().toString() ). | ||
| indexConfigBlobKey( meta.nodeVersionKey().getIndexConfigBlobKey().toString() ). | ||
| accessControlBlobKey( meta.nodeVersionKey().getAccessControlBlobKey().toString() ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Codacy found a minor Performance issue: Avoid calling toString() on String objects; this is unnecessary.
The issue identified by the PMD linter is that the toString() method is being called on a String object, which is unnecessary because a String is already in its string representation. This can lead to a slight performance overhead, especially if this pattern occurs frequently in the codebase.
To fix the issue, we can simply remove the unnecessary toString() call for the accessControlBlobKey. The code suggestion would be:
| accessControlBlobKey( meta.nodeVersionKey().getAccessControlBlobKey().toString() ). | |
| accessControlBlobKey( meta.nodeVersionKey().getAccessControlBlobKey() ). |
This comment was generated by an experimental AI tool.
| final RepositoryService repositoryService; | ||
| final IndexServiceInternal indexServiceInternal; | ||
|
|
||
| public Xp8IndexMigrator( final RepositoryService repositoryService, final IndexServiceInternal indexServiceInternal ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ Codacy found a minor CodeStyle issue: Redundant 'public' modifier.
The issue reported by the Checkstyle linter indicates that the public modifier is considered redundant in this context. This usually occurs when the class is defined in a package-private context, meaning it doesn't need an explicit access modifier for its constructor.
To resolve this issue, you can simply remove the public modifier from the constructor. Here’s the suggested change:
| public Xp8IndexMigrator( final RepositoryService repositoryService, final IndexServiceInternal indexServiceInternal ) | |
| Xp8IndexMigrator( final RepositoryService repositoryService, final IndexServiceInternal indexServiceInternal ) |
This comment was generated by an experimental AI tool.
No description provided.