Rename usage welcome app in ApiHandler #11185 #11186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11186 +/- ##
=========================================
Coverage 86.03% 86.03%
Complexity 19707 19707
=========================================
Files 2573 2573
Lines 67918 67918
Branches 5430 5430
=========================================
Hits 58436 58436
Misses 6887 6887
Partials 2595 2595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rymsha
approved these changes
Jul 4, 2025
rymsha
requested changes
Aug 12, 2025
| private static final Pattern URL_PATTERN = Pattern.compile( "^/api$" ); | ||
|
|
||
| private static final ApplicationKey WELCOME_APP_KEY = ApplicationKey.from( "com.enonic.xp.app.welcome" ); | ||
| private static final ApplicationKey SDK_APP_KEY = ApplicationKey.from( "com.enonic.xp.sdk" ); |
There was a problem hiding this comment.
Suggested change
| private static final ApplicationKey SDK_APP_KEY = ApplicationKey.from( "com.enonic.xp.sdk" ); | |
| private static final ApplicationKey SDK_APP_KEY = ApplicationKey.from( "com.enonic.xp.app.sdk" ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.