Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (build): Fix configuration-path: .bazel-steward.yaml #1177

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix (build): Fix configuration-path: .bazel-steward.yaml #1177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/bazel-steward.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@ name: Bazel Steward 🤵

# See https://github.com/VirtusLab/bazel-steward/issues/420:
permissions:
write-all
# TODO contents: write
# TODO pull-requests: write
contents: write
pull-requests: write
Comment on lines +23 to +24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The change from write-all to specific permissions is a good security practice. However, ensure that contents: write and pull-requests: write are sufficient for Bazel Steward's operations. If Bazel Steward requires other permissions, they should be added explicitly.


# https://virtuslab.github.io/bazel-steward/docs/installation.html

Expand All @@ -45,7 +44,9 @@ jobs:
fetch-depth: 0
- uses: VirtusLab/[email protected]
# NB: Cannot use hash instead of version here due to
# https://github.com/VirtusLab/bazel-steward/issues/414.
# TODO https://github.com/VirtusLab/bazel-steward/issues/414.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This TODO comment should be tracked and addressed in a future issue or pull request. Consider creating a GitHub issue to track this.

with:
# NB: https://github.com/VirtusLab/bazel-steward/issues/419
configuration-path: .bazel-steward.yaml
github-personal-token: ${{ secrets.BAZEL_STEWARD }}
additional-args: "--update-all-prs"
Loading