Skip to content

Commit

Permalink
fix (build): Run pnpm on GitHub Action (until later Bazel integration)
Browse files Browse the repository at this point in the history
  • Loading branch information
vorburger committed Jan 15, 2025
1 parent bf437ae commit a6c5314
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
24 changes: 24 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,30 @@ jobs:
steps:
- uses: actions/checkout@v4

# TODO Remove pnpm/action-setup after switching to using https://github.com/aspect-build/rules_ts (?)
- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 10 # Keep pnpm version in sync with web/README.md
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22
cache: "pnpm"
cache-dependency-path: web/pnpm-lock.yaml
- name: Install Web dependencies
working-directory: web
run: pnpm install
- name: Test Web
working-directory: web
run: pnpm test
- name: Run TSC
working-directory: web
run: pnpm run tsc
- name: Build Web
working-directory: web
run: pnpm run build

- uses: actions/setup-java@v4
with:
distribution: "temurin"
Expand Down
2 changes: 1 addition & 1 deletion web/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

1. `cd web/`

1. One time `npm install -g pnpm@latest-10`
1. One time `npm install -g pnpm@latest-10` <!-- NB: Keep pnpm version in-sync with pnpm/action-setup in ci.yaml -->

1. One time `pnpm install` (TODO: Replace with Bazel...)

Expand Down

0 comments on commit a6c5314

Please sign in to comment.