[PLA-2500] Update to Enjin Platform SDK 3.0.4 - #9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the sample server to Enjin Platform SDK 3.0.4 and aligns transaction completion logic with the SDK’s documented semantics, ensuring a transaction being Finalized is not treated as success when it still reports an error (e.g., partial failure in batch extrinsics).
Changes:
- Bump
Enjin.Platform.Sdkfrom3.0.3to3.0.4. - Harden
WaitForFinalizationAsyncto request and evaluateTransaction.Error(andFailedItemIndexes) soFinalized+ non-emptyErrorfails fast with a clearer exception message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Services/EnjinService.cs | Adds Error/FailedItemIndexes to the polled transaction fields and treats Finalized as success only when Error is empty; improves terminal-state error reporting. |
| PlatformSampleGameServer.csproj | Updates Enjin Platform SDK dependency to 3.0.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the Enjin.Platform.Sdk PackageReference from 3.0.3 to 3.0.4 and harden transaction completion checking to match the semantics 3.0.4 documents.
The bump itself needs no source changes. 3.0.4's breaking changes are confined to surface this server does not use: the GetCompatibleFuelTanks arguments (pallet/method replaced by transactions/batchMode), the CompatibleFuelTank budget fields, infusion/unitPrice retyped from BigInteger to string, and FuelTankRuleSet.WhitelistedPallets retyped to an enum collection.
Also fixes a pre-existing bug in WaitForFinalizationAsync, which treated state FINALIZED as success and discarded the transaction's error. Per 3.0.4's Transaction.Error documentation, a batch extrinsic still finalizes on-chain when wrapped items fail to dispatch, so FINALIZED alone does not mean the requested work happened.