Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component docs update #197

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Component docs update #197

merged 11 commits into from
Feb 27, 2024

Conversation

macdonst
Copy link
Contributor

No description provided.

colepeters
colepeters reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@colepeters colepeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging these updates! A few suggestions for clarity/grammar :)

app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
@macdonst macdonst marked this pull request as ready for review February 26, 2024 19:51
tbeseda
tbeseda approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@tbeseda tbeseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great summary of components and also the general idea of progressive enhancement 👍

colepeters
colepeters reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@colepeters colepeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Few more suggestions on a second/Monday reading, feel free to @ me if you wanna discuss any! :)

app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
app/docs/md/conventions/components.md Outdated Show resolved Hide resolved
colepeters
colepeters approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@colepeters colepeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 ✨

@macdonst macdonst merged commit dc3a7b5 into main Feb 27, 2024
4 checks passed
@macdonst macdonst deleted the component-docs branch February 27, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbeseda tbeseda tbeseda approved these changes

@colepeters colepeters colepeters approved these changes

@kristoferjoseph kristoferjoseph Awaiting requested review from kristoferjoseph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macdonst @tbeseda @colepeters