moq-transport: Fix u8 encoding #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes u8 encoding so we can encode values larger than 64. Previously we were incorrectly encoding values larger than 64 as varints, including the current default subscriber priority of 127, and then incorrectly decoding those mis-encoded values as 64. I introduced this bug in 7eeecb7 Thanks to @TilsonJoji for helping to identify the issue in #9
englishm
force-pushed
the
me/fix-u8-encode
branch
from
ce04db7 to
d0e5de0
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes u8 encoding so we can encode values larger than 64.
Previously we were incorrectly encoding values larger than 64 as
varints, including the current default subscriber priority of 127, and
then incorrectly decoding those mis-encoded values as 64.
I introduced this bug in 7eeecb7
Thanks to @TilsonJoji for helping to identify the issue in #9