Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new product] Sourcegraph #4914

Merged
merged 24 commits into from
Apr 8, 2024
Merged

Conversation

Alexm0812
Copy link
Contributor

No description provided.

@captn3m0 captn3m0 changed the title add product sourcegraph [new product] Sourcegraph Mar 31, 2024
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR. left a few suggestions, happy to discuss further. The main one is the lack of an upstream release policy link.

@Alexm0812
Copy link
Contributor Author

Thank you for the suggested changes. I have now included a policy release document link that I believe will be sufficent and contains important information regarding releases

@Alexm0812 Alexm0812 requested a review from captn3m0 April 1, 2024 16:32
Copy link
Contributor Author

@Alexm0812 Alexm0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes made

Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Alexm0812, it's almost good to me, but I have a few more comments / suggestions.

Copy link
Contributor Author

@Alexm0812 Alexm0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcwrobel thank you for the suggestions. I have committed these now and everything should be good.

@Alexm0812 Alexm0812 requested a review from marcwrobel April 5, 2024 00:48
@captn3m0
Copy link
Member

captn3m0 commented Apr 5, 2024

https://handbook.sourcegraph.com/departments/engineering/dev/process/releases/#support-for-older-versions says:

At Sourcegraph, we’re committed to providing the best support possible for our users. As such, we offer support for the latest version (N) and its previous major version (N-1). For instance, if version 5.x is the most recent release, we provide support for both 5.x and 4.x.

It’s important to note that we do not backport bug fixes or other improvements into older versions. Our team is focused on resolving issues in the latest versions of our products.

Should we mark v4 as supported given this? It is unclear what their definition of "support" is, if there are no backports at all, and security backports are also not mentioned. Is it just that they will reply to support tickets?

@captn3m0
Copy link
Member

captn3m0 commented Apr 5, 2024

Relevant PR: sourcegraph/handbook#6828. I've filed sourcegraph/handbook#8847

@Alexm0812
Copy link
Contributor Author

I had considered this however I saw it as they don’t provide “full support” I thought it be best to say that no support is given. Although they provide some support I don’t think it’s enough to consider it as say they provide support especially as no backports are done and it seems no security backports either.

@Alexm0812
Copy link
Contributor Author

I can confirm no security or bug fixes are done for older versions. “For older versions of Sourcegraph, the primary support offered involves assistance with upgrading to a supported version. While Sourcegraph does not backport bug fixes or improvements to older versions, the team encourages users to update to the latest versions to benefit from new features and fixes. This approach ensures users have the most secure and efficient version of the software, but specific help for outdated versions, beyond upgrade guidance, may be limited.”

Since we are marking v4 as unsupported deliberately,
against what the upstream says - we need to be
clear why there is a disparity.
Copy link
Member

@captn3m0 captn3m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can update further if we get clarity from upstream.

Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Apr 8, 2024
@marcwrobel marcwrobel merged commit 9abbbb2 into endoflife-date:master Apr 8, 2024
5 checks passed
Copy link

welcome bot commented Apr 8, 2024

Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉.

@captn3m0
Copy link
Member

captn3m0 commented Apr 9, 2024

@Alexm0812 Thanks for your contribution 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants