Move package editable install to requirements.txt #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiangolo
approved these changes
Sep 29, 2020
|
yes but this fails the CI because wsproto as agreed in #666 (for the real comment it's one issue above in #298 (comment)) is left at user's discretion and we need it for the tests |
euri10
reviewed
Sep 29, 2020
br3ndonland
added a commit
to br3ndonland/inboard
that referenced
this pull request
Oct 3, 2020
https://github.com/encode/uvicorn/releases/tag/0.12.1 https://github.com/encode/uvicorn/blob/master/CHANGELOG.md encode/uvicorn#666 encode/uvicorn#788 encode/uvicorn#790 encode/uvicorn#792 encode/uvicorn#794 #13 079b432 059e28b Uvicorn now separates its optional dependencies from the base package installation. The install command is `poetry add "uvicorn[standard]"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team!
Quick tweak to the
requirements.txtso that it's treated as the "all dev dependencies" file. Basically drops the duplicate requirements in favor of using those specified insetup.py, by installing-e .[standard].