Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete js folder and remove extra_javascript #2136

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Delete js folder and remove extra_javascript #2136

merged 2 commits into from
Nov 1, 2023

Conversation

MhmoudGit
Copy link
Contributor

Summary

I found an issue about the chat button not working on website and there was a suggestion to remove the docs/js files.
So I deleted the extra_javascript in mkdocs.yaml and the js folder altogether.

Impact

This will remove the "Open Chat" button from the docs website.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@zanieb
Copy link

zanieb commented Nov 1, 2023

@MhmoudGit thanks for contributing. Which issue are you referring to?

@MhmoudGit
Copy link
Contributor Author

Hi @zanieb, I did the same PR regarding issue #2303 on starlette and @Kludex asked if I can do the same PR in uvicorn and httpx so I did this one and on httpx as well.

@Kludex
Copy link
Member

Kludex commented Nov 1, 2023

Can we link the other PRs here? 👀

@MhmoudGit
Copy link
Contributor Author

MhmoudGit commented Nov 1, 2023

The one on httpx was approved, merged and closed so only this and starlette are opened for now.
Do you mean I should put a link here? or that question wasn't for me? 😅

@Kludex
Copy link
Member

Kludex commented Nov 1, 2023

@Kludex Kludex merged commit 07c2b36 into encode:master Nov 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants