Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using h2 give it priority in tls alpn. In general order of tls alpn is important and servers mostly choose the first version that they support, by setting http1.1 first most server will actually negotiate http1.1
Also don't specify http1.1 if only h2 is enabled. This could otherwise lead to negotiating something that is not supported, which was especially bad when the wrong order was used.
Found this actually when forcing httpcore to use h2 only and then wireshark failing to decode traffic because tls negotiated http1.1 but we were actually using h2
Checklist