Skip to content

Add GitHub Actions Workflows for Django Testing, Pylint, and Black #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

youzarsiph
Copy link
Contributor

Description

This pull request adds three GitHub Actions workflows to the Django REST Framework repository to enhance code quality and streamline the development process. The following workflows have been implemented:

  1. Django CI:

    • Purpose: Automatically run Django tests on every push and pull request.
    • Configuration: Sets up Python, installing dependencies as specified in requirements.txt.
  2. Pylint:

    • Purpose: Integrate static code analysis using Pylint to ensure code quality and adherence to coding standards.
    • Configuration: Installs Pylint and runs it against the specified Django app directory.
  3. Black:

    • Purpose: Automatically check code formatting using Black, ensuring consistent code style across the project.
    • Configuration: Installs Black and checks the formatting of the specified Django app directory.

Benefits

  • Improves code quality through automated testing and linting.
  • Enforces coding standards with Black and Pylint.
  • Reduces manual effort in running tests and styles checks, allowing for quicker feedback in the development process.

Thank you for considering my contribution!

Copy link
Contributor

@ulgens ulgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo already has pre-commit in place, I wouldn't recommend adding a new workflow for any of these.

Also, with the current state of Python tooling, I wouldn't even recommend using these tools as theirselves. Ruff would be nice a improvement but not sure whether it counts as "churn"

@browniebroke
Copy link
Member

No thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants