Fix sqlalchemy default values for insert and update queries #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astret-soft
reviewed
Feb 10, 2021
| @@ -917,6 +1009,7 @@ async def run_database_queries(): | |||
| async with database: | |||
|
|
|||
| async def db_lookup(): | |||
|
|
|||
acnebs
reviewed
Feb 20, 2021
| _result_processors = {} # type: dict | ||
|
|
||
|
|
||
| class APGCompiler_psycopg2( |
There was a problem hiding this comment.
Seems strange to call this APGCompiler_psycopg2, given that the db backend used for postgres in databases is asyncpg, not psycopg2.
There was a problem hiding this comment.
this is how aiopg calls it
https://github.com/encode/databases/blob/master/databases/backends/aiopg.py#L32#L35
There was a problem hiding this comment.
Right but that's because aiopg is just a wrapper around psycopg2, asyncpg is not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what actually
aiopgdoes https://github.com/aio-libs/aiopg/blob/master/aiopg/sa/engine.py#L17#L30Fixes #72
I think this solution is less tricky than #206