bugfix - bound run command generated target cache (#797)#798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
incan run -cartifact growth by replacing timestamped inline command project names with stable content-keyed identities. Repeated identical inline snippets from the same working directory now reuse the same generated project and Cargo binary, while different snippets still get separate stable targets so parallelrun -cinvocations cannot execute the wrong binary.Type of change
docs/RFCs/*)Area(s)
Select the primary areas touched (used for review routing; labels are managed separately):
Key details
incan run -ccalls no longer mint newincan_cmd_*generated Cargo targets for the same inline source.Testing / verification
make test/cargo testmake examples(if relevant)incan fmt --check .(if relevant)Manual verification notes:
cargo test --locked inline_command --libpassed: 6 focused unit tests.cargo test --locked test_run_c_import_this --test integration_testspassed: 2 existingrun -cintegration tests.cargo build --locked --bin incanpassed.incan run -c 'import this'twice from the same throwaway directory reused the existing debug binary on the second run.incan run -cwith a different snippet from the same directory created a different stableincan_inline_command_<digest>crate instead of colliding with the first snippet.find <throwaway-target> -name 'incan_cmd_*'returned no results.make pre-commitpassed: 2,682 nextest tests, clippy, cargo-deny and smoke-test-fast.Docs impact
If docs updated:
Checklist
Closes #797