feature - add portable plan-validation backend (#22)#100
Draft
dannymeijer wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a portable plan-validation backend for IncQL sessions so Substrait plan construction can be validated without using DataFusion as the execution owner. This keeps the architecture aligned with the authoring/query surface -> Prism -> Substrait IR -> backend adapter boundary while providing a non-executing backend path for plan-shape checks.
Closes #22.
Type of change
docs/rfcs/*)Area(s)
Select the primary areas touched (labels sync from checked lines when the triage workflow runs):
Key details
Session.plan_validation_backend()/Session.builder().with_plan_validation(...)for validation-only plan construction. The backend accepts valid plans throughexecute(...)and returns typed backend errors for materialization and write paths.BackendKind.PlanValidationEngine,PlanValidationBackendConfig, backend selection encoding/decoding, and a dispatcher path that validates Substrait plan roots without delegating semantics to DataFusion.Testing / verification
make ci(ormake fmt-check,make build,make test)Manual verification notes:
/Users/danny/Development/encero/tmp/incan-v0.4.0-bin/bin/incan --version->incan 0.4.0git diff --checkmake test-stylemake fmt-check INCAN=/Users/danny/Development/encero/tmp/incan-v0.4.0-bin/bin/incanmake build INCAN=/Users/danny/Development/encero/tmp/incan-v0.4.0-bin/bin/incan/Users/danny/Development/encero/tmp/incan-v0.4.0-bin/bin/incan fmt --check src/Users/danny/Development/encero/tmp/incan-v0.4.0-bin/bin/incan fmt --check tests/test_session_backend_plan_validation.incn/Users/danny/Development/encero/tmp/incan-v0.4.0-bin/bin/incan test tests/test_session_backend_plan_validation.incn -x --nocapture-> 7 passedDocs impact
If docs updated:
docs/language/reference/execution_context.md,docs/release_notes/v0_1.mdChecklist