Replace python subprocess's universal_newlines with text. NFC
#23627
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Feb 8, 2025
sbc100
force-pushed
the
universal_newlines
branch
2 times, most recently
from
d509c95 to
aeb0006
Compare
In python 3.7 the `universal_newlines` parameter was deprecated in favor of the more readable `text` parameter. We updated our minimum supported python version to 3.8 in emscripten-core#23417.
sbc100
force-pushed
the
universal_newlines
branch
from
aeb0006 to
0cbe487
Compare
hoodmane
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.7 the
universal_newlinesparameter was deprecated in favor of the more readabletextparameter.We updated our minimum supported python version to 3.8 in #23417.