[jspi] Fix TSD generation when using asyncify library functions. #23419
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of disabling JSPI during TSD generation just skip instrumenting the wasm exports and imports so JSPI isn't needed. Fixes emscripten-core#23418
sbc100
reviewed
Jan 15, 2025
| let HEAPU32: any; | ||
| let HEAP64: any; | ||
| let HEAPU64: any; | ||
| } |
There was a problem hiding this comment.
I guess this is a side effect of adding -sSTRICT? Is that related to this change somehow?
There was a problem hiding this comment.
Yeah, strict will remove those definitions. The reporters issue only happened in strict mode, since it turns on erroring on undefined symbols.
sbc100
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of disabling JSPI during TSD generation just skip instrumenting the wasm exports and imports so JSPI isn't needed.
Fixes #23418