Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop): fix i18n issues #1898

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix(desktop): fix i18n issues #1898

merged 1 commit into from
Mar 18, 2025

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Mar 18, 2025

PR Checklist
If you have any questions, you can refer to the Contributing Guide.

What is the current behavior?
Currently, translations for several phrases are split across two files: common.ts and copilot.ts.

Issue Number
Example: #123

What is the new behavior?
Translations for phrases such as 'See More', 'View Data', 'Save to Local', 'Message Type', and time intervals ('Last 5 Minutes', 'Last 30 Minutes', etc.) have been moved from copilot.ts to common.ts. This consolidates the translations into a single file, reducing redundancy and improving maintainability.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

  • Verify that no references to the removed translations in copilot.ts are broken.
  • Ensure that all references are correctly updated to point to common.ts.

Other information

  • The common.ts file now includes the translations for:
    • seeMore
    • viewData
    • saveToLocal
    • msgType
    • Time intervals such as last5Minutes, last30Minutes, lastHour, lastDay, lastWeek, startTime, and endTime.
  • The copilot.ts file has had the corresponding translations removed.

@ysfscream ysfscream added fix Fix bug or issues desktop MQTTX Desktop labels Mar 18, 2025
@ysfscream ysfscream added this to the v1.12.0 milestone Mar 18, 2025
@ysfscream ysfscream requested a review from Red-Asuka March 18, 2025 05:47
@ysfscream ysfscream self-assigned this Mar 18, 2025
@Red-Asuka Red-Asuka merged commit cd92589 into main Mar 18, 2025
4 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch March 18, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop fix Fix bug or issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants