fix(desktop): fix sqlite disconnect warning issue #1897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
When closing the application, an unhandled promise rejection occurs with error:
SQLITE_MISUSE: Database handle is closed
. This happens because the application attempts to close the database connection multiple times during the shutdown process, causing errors when trying to close an already closed connection.Issue Number
What is the new behavior?
Added safeguards to prevent multiple database connection close attempts:
This prevents the unhandled promise rejection and ensures a clean application shutdown.
Does this PR introduce a breaking change?
Specific Instructions
No special instructions needed. This fix addresses the database connection closure error without changing any application functionality.
Other information
The error occurred because both the window's
close
event handler and the app'swindow-all-closed
event handler were attempting to close database connections, leading to the same connection being closed twice.