Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pkg): update node engine versiont to 16 #1853

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

At present, the engine setting >= 16, but v18 cannot run, so we need to fix the node version to v16.

Issue Number

Example: #1833

What is the new behavior?

❯ yarn
yarn install v1.22.22
[1/6] 🔍  Validating package.json...
error [email protected]: The engine "node" is incompatible with this module. Expected version "16". Got "18.17.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added dependencies Pull requests that update a dependency file chore Changes in build tools or dependent packages desktop MQTTX Desktop labels Jan 7, 2025
@ysfscream ysfscream added this to the v1.12.0 milestone Jan 7, 2025
@ysfscream ysfscream requested a review from Red-Asuka January 7, 2025 02:04
@ysfscream ysfscream self-assigned this Jan 7, 2025
@Red-Asuka Red-Asuka merged commit 16fd38a into main Jan 8, 2025
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch January 8, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes in build tools or dependent packages dependencies Pull requests that update a dependency file desktop MQTTX Desktop
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants