Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial saml implementation #612

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

initial saml implementation #612

wants to merge 45 commits into from

Conversation

alexBLR
Copy link
Contributor

@alexBLR alexBLR commented Nov 4, 2024

This Implementation currently lives on Arch

Copy link

codeclimate bot commented Nov 13, 2024

Code Climate has analyzed commit adef9f9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 87.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.2% (-0.2% change).

View more on Code Climate.

@alexBLR alexBLR marked this pull request as ready for review November 13, 2024 19:29
@alexBLR alexBLR marked this pull request as draft November 14, 2024 16:44
@alexBLR alexBLR marked this pull request as ready for review February 4, 2025 18:12
@alexBLR alexBLR requested a review from bwatson78 February 4, 2025 18:12
Copy link
Contributor

@bwatson78 bwatson78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexBLR Done my review. Just the changes we already talked about are necessary.

app/models/user.rb Outdated Show resolved Hide resolved
app/models/user.rb Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
@alexBLR alexBLR requested a review from bwatson78 February 10, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants