- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4
HHH-9265 preview - Extract EntityEntry behind a factory + interface #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            emmanuelbernard
  wants to merge
  2,448
  commits into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
HHH-9265
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …small contents and almost no writes
…rentServiceBinding
- unnecessary HashMap lookups - size HashMap allocations appropriately - a leak of tracked statements - complex logging logic
StatefulPersistenceContext's Map#resize calls
… some assertEquals statements
…hen the session factory is built. This allows for Configuration#getProperties to return writable properties Re-enabling tests which were based on the change in Configuration
stripped SQL generation from metamodel.spi.relational constraints, created applyConstraints/dropConstraints on Dialect
ConstraintDelegate, created UK exporters for DB2 and Informix
explicit FK names, corrected default annotation values, initial unit test
(cherry picked from commit f549b88831ec23da7c44ef026b61f2cb8c5246ed)
…edOps() removed by HHH-9078; deprecate method added by HHH-9078 (cherry picked from commit 420296fd267c8bcf9501896fcc17446c55b1d272)
(cherry picked from commit d36b3a3e976faf0db8976c5e4a513216aead94cf)
This reverts 700a233, except for tests.
(cherry picked from commit 95070f50a9a1e4d7fb0e2ff06331a4c9ef440187) Conflicts: hibernate-envers/src/test/java/org/hibernate/envers/test/integration/components/collections/mappedsuperclasselement/CollectionOfMappedSuperclassComponentsTest.java hibernate-envers/src/test/java/org/hibernate/envers/test/integration/components/mappedsuperclass/EmbeddableWithDeclaredDataTest.java hibernate-envers/src/test/java/org/hibernate/envers/test/integration/components/mappedsuperclass/EmbeddableWithNoDeclaredDataTest.java
Conflicts: hibernate-core/src/test/java/org/hibernate/test/onetoone/link/OneToOneLinkTest.java
Conflicts: hibernate-core/src/test/java/org/hibernate/test/generated/DefaultGeneratedValueTest.java
(cherry picked from commit dad4c64d5694262eee86f4645ac61dffa489b03e) Conflicts: hibernate-infinispan/src/test/java/org/hibernate/test/cache/infinispan/functional/BasicTransactionalTestCase.java
(cherry picked from commit af5791f6dd5b8b82e4786a146375e583c12037b7) Conflicts: hibernate-infinispan/src/test/java/org/hibernate/test/cache/infinispan/functional/BasicTransactionalTestCase.java
(cherry picked from commit 70532259faa14064cff8263cbb7ad6d82d607892) Conflicts: hibernate-core/src/test/java/org/hibernate/test/ops/MergeTest.java hibernate-core/src/test/resources/log4j.properties
…pies with dirty collections (cherry picked from commit c7c5b015c134df993de4105a2bc3e70d7e14ad68)
(cherry picked from commit 2daaf9a1965b70897928ea222ea8708acaad3bbd) Conflicts: hibernate-core/src/test/resources/log4j.properties
…ymanager test cases) (cherry picked from commit 055b0cacaec4fbb136a1fc592fa00cb7e950eb61)
…ved logging) (cherry picked from commit fed3191)
…BASE ASE (cherry picked from commit 257efd1)
(cherry picked from commit 3a8041953d950db15513cecc36db38ee286c8a30)
…query (cherry picked from commit 133f082)
Make sure serialization uses interface getters
…constructor call serialization / deserialization is not dealt with so far
| test are hanging here the same. BTW how many commits are in this PR? ;-) | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
@Sanne here is the interface extraction for
EntityEntry. Next is to work on the chaining approach.I have something weird on my machine where gradle hangs, can you run the tests?