Test solvers design #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self._tests = {} | ||
|
|
||
| def _get_or_create_test_meta(self, func: Callable) -> SolverTestMeta: | ||
| name = func.__name__ |
There was a problem hiding this comment.
I worry about name conflicts here.
There was a problem hiding this comment.
Let's use the function and the name to identify name conflicts and raise errors?
Comment on lines
+18
to
+23
| include: Optional[List[Union[str, re.Pattern]]] = None, | ||
| exclude: Optional[List[Union[str, re.Pattern]]] = None, | ||
| include_tags: Optional[List[str]] = None, | ||
| exclude_tags: Optional[List[str]] = None, | ||
| warn_unsupported: bool = False, | ||
| warn_unavailable: bool = False, |
There was a problem hiding this comment.
Can you describe each of these in a docstring?
There was a problem hiding this comment.
Particularly the first two. They are not obvious to me.
| pass | ||
|
|
||
|
|
||
| add_tests(TestSolvers, GurobiDirect) |
There was a problem hiding this comment.
Does the order in which python imports files matter here?
There was a problem hiding this comment.
Maybe this is just something we address with documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just to start review of the test solvers suite.