Add ID to advanced fluid tooltips in Forge#952
Open
bb010g wants to merge 1 commit intoemilyploszaj:1.21from
Open
Add ID to advanced fluid tooltips in Forge#952bb010g wants to merge 1 commit intoemilyploszaj:1.21from
bb010g wants to merge 1 commit intoemilyploszaj:1.21from
Conversation
Owner
|
Sorry for such a long delay on review, please remove the changelog entry, those are manually introduced at time of release, otherwise looks fine. |
This backports the equivalent feature in NeoForge that was introduced in 2975b06.
bb010g
force-pushed
the
topic/forge-advanced-tooltips-fluid-id/1.21
branch
from
52ec05b to
85d341c
Compare
Author
|
@emilyploszaj Done & pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the equivalent feature in NeoForge that was introduced in 2975b06.
reference merges into newer target versions can be found at:
reference merges into older target versions can be found at:
https://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.20.5 (trivial)
https://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.20.4 (trivial)
https://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.20.2 (trivial)
newest target version with Forge. tested via
:forge:runClienthttps://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.20 (trivial)
tested via
:forge:runClienthttps://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.19.4 (trivial)
https://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.19.3 (trivial)
https://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.19.2 (trivial)
builds are successful down to https://github.com/catgirl-v/emi/tree/topic/forge-advanced-tooltips-fluid-id/next/1.19.2.
also tested in:
https://github.com/catgirl-v/emi/tree/1.20
includes catgirl-v's other downstream patches. tested via
github:catgirl-v/pissfactory#pack-hardmode(Monifactory downstream)