Skip to content

Do not retain JEMI layout builder for every recipe #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilyploszaj merged 1 commit into from
May 17, 2025
Merged

Do not retain JEMI layout builder for every recipe #951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xplat/src/main/java/dev/emi/emi/jemi/JemiRecipe.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public class JemiRecipe<T> implements EmiRecipe {
public Identifier originalId, id;
public IRecipeCategory<T> category;
public T recipe;
public JemiRecipeLayoutBuilder builder = new JemiRecipeLayoutBuilder();
public boolean allowTree = true;

public JemiRecipe(EmiRecipeCategory recipeCategory, IRecipeCategory<T> category, T recipe) {
Expand All @@ -55,6 +54,7 @@ public JemiRecipe(EmiRecipeCategory recipeCategory, IRecipeCategory<T> category,
if (this.originalId != null) {
this.id = EmiPort.id("jei", "/" + EmiUtil.subId(this.originalId));
}
JemiRecipeLayoutBuilder builder = new JemiRecipeLayoutBuilder();
category.setRecipe(builder, recipe, JemiPlugin.runtime.getJeiHelpers().getFocusFactory().getEmptyFocusGroup());
for (JemiRecipeSlotBuilder jrsb : builder.slots) {
jrsb.acceptor.coerceStacks(jrsb.tooltipCallback, jrsb.renderers);
Expand Down