Draft
Conversation
# Conflicts: # xplat/src/main/java/dev/emi/emi/network/CommandS2CPacket.java
Feature/emi share recipe
# Conflicts: # xplat/src/main/java/dev/emi/emi/screen/EmiScreenManager.java
emilyploszaj
requested changes
Nov 30, 2025
Owner
emilyploszaj
left a comment
There was a problem hiding this comment.
I'm not sure I enjoy this feature implementation route, but at the very least you need to adhere to codebase style, this codebase uses tabs and not spaces, it's making diffs hard to read, please fix this.
Author
|
Sorry for the spaces @emilyploszaj. As you might have guesed I am kinda new to this. |
|
This is really good! Hope it can be merged! |
|
Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a multiplayer-centric feature allowing players to broadcast specific recipes to the server chat. This addresses the common issue in complex modpacks where verbally describing a recipe or item name is difficult.
Features
Demo
Demo_v1.webm
Technical Implementation
Areas for Review / Feedback Needed
I would appreciate specific feedback on the following implementation details:
CommandS2CPacket.javato include the player'sdisplayName. Please verify if this modification approach is acceptable regarding backward compatibility or protocol standards.EmiCommands.javaso standard players (Level 0) can use the feature, as recipe sharing should not require admin privileges.buttons.pngandwidgets.png. I attempted to match the existing EMI aesthetic but would like confirmation that these fit the design standards. Also files have different size, I hope I did save it correctly.CommandS2CPacket.applywas triggering multiple times for a single event.EmiShareRecipe.javacomparing the share history with the latest item to prevent the UI from updating multiple times and displaying duplicite chat messages to player.Related Files
xplat/src/main/resources/assets/emi/textures/gui/buttons.pngxplat/src/main/resources/assets/emi/textures/gui/widgets.pngxplat/src/main/java/dev/emi/emi/network/CommandS2CPacket.javaxplat/src/main/java/dev/emi/emi/registry/EmiCommands.javaxplat/src/main/java/dev/emi/emi/runtime/EmiShareRecipe.java