-
Notifications
You must be signed in to change notification settings - Fork 23
Full refresh into a fully typed ESM module etc #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
voxpelli
wants to merge
23
commits into
emilbayes:master
Choose a base branch
from
voxpelli:upstreamable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
I made a maintenance fork over at
@voxpelli/secure-password
. I kept the changes separate so that I could create a PR for it here.Warning
I do not assume that you will want to merge this up front as is, you of course can, but my assumption is that you wont. This PR is for visibility more than merging.
Important
I'm very open to reshaping this PR into what you would feel more comfortable merging, eg. dropping some of the dev tooling and eg. replacing
@voxpelli/eslint-config
withneostandard
and such.From the
CHANGELOG.md
entry I wrote for thev5.0.0
release I made:Breaking changes
^20.15.0 || >=22.2.0
SecurePassword
as a named exportSecurePassword
now needs to be created withnew
, egnew SecurePassword()
Changes
sodium-native
v5.xnanoassert
Internal changes
tape
fornode:test
The following is an additional overview generated by GitHub Copilot to make it easier to digest the contents, sorry for use of AI.
This pull request introduces significant updates to modernize the project, improve workflows, and align with current development standards. Key changes include migrating to GitHub Actions for CI/CD, dropping legacy support, adopting modern tooling, and transitioning to ESM. Additionally, it includes updates to documentation and configuration files to reflect these changes.
CI/CD Migration and Workflow Enhancements:
.travis.yml
andappveyor.yml
with GitHub Actions workflows for dependency review, linting, and Node.js testing. These workflows use templates fromvoxpelli/ghatemplates
. (.github/workflows/dependency-review.yml
- [1].github/workflows/lint.yml
- [2].github/workflows/nodejs.yml
- [3].husky/pre-push
to run tests automatically before pushing changes.Breaking Changes and Modernization:
SecurePassword
to be imported as a named export and instantiated withnew
. Dropped callback support in favor of Promises and updated Node.js compatibility to^20.15.0 || >=22.2.0
. (CHANGELOG.md
- [1]README.md
- [2]README.md
- README.mdL3-R227)Configuration Updates:
.editorconfig
to enforce consistent coding standards across the project (e.g., LF line endings, UTF-8 charset, and 2-space indentation).declaration.tsconfig.json
for generating TypeScript type declarations..npmrc
to disablepackage-lock
.Tooling Improvements:
tape
withnode:test
for testing and added more test coverage. (CHANGELOG.md
- CHANGELOG.mdR3-R29)@voxpelli/eslint-config
for consistent code quality checks. (eslint.config.js
- eslint.config.jsR1-R3)Removal of Legacy Files:
.travis.yml
andappveyor.yml
) as part of the migration to GitHub Actions. (.travis.yml
- [1]appveyor.yml
- [2]