More assets lint fixes #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Let's put this on hold until we are done with #59 |
Owner
|
Authorized Now so that the changes could be tested live. So far so good :) |
emedvedev
approved these changes
Nov 23, 2019
XhmikosR
commented
Jan 11, 2020
| var wp = 'slackin-width:' + id + ':' | ||
| if (wp === e.data.substr(0, wp.length)) { | ||
| var width = e.data.substr(wp.length) | ||
| if (wp === e.data.slice(0, wp.length)) { |
Collaborator
Author
There was a problem hiding this comment.
@emedvedev can you confirm the slice changes are OK? I'm going through the diff after 1.1.11
Owner
There was a problem hiding this comment.
Should be the same in this case, yes.
Collaborator
Author
There was a problem hiding this comment.
I meant all of the substr to slice changes, just to be safe :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about all these. I mean for one I don't think
for...inshould be used in all these cases. Which is also an error ofno-restricted-syntax.Most of the strict equality checks should be fine, but let's triple check