Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize python env and version data #478

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

fabianliebig
Copy link
Collaborator

@fabianliebig fabianliebig commented Feb 7, 2025

Hi all,

this PR adds an unstructure hook to the result class to include the init=False attribute in the JSON. The current setting ignores these values so that the environment and version information is collected but won't become part of the stored file.

Copy link
Collaborator

@Scienfitz Scienfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bugfix? PR description and label should indicate this if thats the case

@fabianliebig fabianliebig added the bug Something isn't working label Feb 7, 2025
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for taking care of it!

@AdrianSosic AdrianSosic merged commit ac8c518 into main Feb 7, 2025
7 of 11 checks passed
@AdrianSosic AdrianSosic deleted the fix/benchmark/python_env branch February 7, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarking bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants